user_nicename being rewritten when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is enabled and username has spaces

[boonebgorges]

See #2642 and http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/profile-page-404-after-1-5-upgrade/.

The same thing is arising when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is set to true, according to the report in the support forum. Should be examined to see if we can recreate.

At a glance, I'm not sure why in r3675 I opted to return the value untouched when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is *false*. Seems like it should be the opposite, since when BP_ENABLE_USERNAME_COMPATIBILITY_MODE is false, a value with a space should never be passed to bp_core_strip_username_spaces(). But this needs more examination.

Marking with a low priority, as it appears to be quite an edge case.

[nurturepact]

I am having these same problems. I have tried everything suggested but have it is not resolved.

[boonebgorges]

Cleaning out the milestone. I'll have a closer look after 1.6.

[r-a-y]

Closing this in favor of #4622.