WP 3.4 deprecated theme functions

[boonebgorges]

WP 3.4 deprecates several items currently in use by BP:

• Notice: add_custom_background is deprecated since version 3.4! Use add_theme_support( 'custom-background', $args ) instead. in /sites/ciab/wp-includes/functions.php on line 2708

• Notice: add_custom_image_header is deprecated since version 3.4! Use add_theme_support( 'custom-header', $args ) instead. in /sites/ciab/wp-includes/functions.php on line 2708

• get_themes() deprecated by wp_get_themes() during installation wizard

[boonebgorges]

Notice: current_theme_info is deprecated since version 3.4! Use wp_get_theme() instead. bp-core-functions.php:242

[chrisclayton]

The deprecated theme info message was getting on my nerves :)

[chrisclayton]

3rd time lucky?

[boonebgorges]

(In [5978]) Adds support for WP 3.4 theme functions. Fixes #4098

[fanquake]

Looks like a typo might have slipped into [5978]
Line 559 "$installad_themes" should probably be "$installed_themes"

[boonebgorges]

(In [5979]) Adds support for WP 3.4 theme functions. Fixes #4098. Props chrisclayton

[boonebgorges]

(In [5980]) Fixes typo from r5978. Antiprops boonebgorges. Props fanquake. See #4098

[boonebgorges]

(In [5981]) Fixes incorrect variable name from r5979. See #4098

[johnjamesjacoby]

Still not quite done here. Both $ct and $ct->tags can be empty, which will dump a notice.

Should also do a function_exists() check instead of a version check.

[DJPaul]

Also related:

[14-May-2012 21:28:27] PHP Warning: Illegal offset type in /Users/paul/Sites/master/wp-content/plugins/buddypress/bp-core/admin/bp-core-update.php on line 558

During install wizard, non-multisite.

[Mamaduka]

Updated patch with JJJ's suggestion, also improved custom header implementation, constants should be used for backward-compatibility.

As DJPaul said, $installed_themes[$current_theme] will trigger the warning. Also not sure if installed themes array is needed at all.

This would be enough:

if ( !empty( $current_theme['Screenshot'] ) ) {
	$screenshot = trailingslashit( get_stylesheet_directory_uri() ) . $current_theme;
}

[DJPaul]

Had a quick look at 4098.diff -- it uses $custom_background_args when its not set (in the not-3.4 if).

[Mamaduka]

Replying to DJPaul:

Had a quick look at 4098.diff -- it uses $custom_background_args when its not set (in the not-3.4 if).

Sorry for that, quick fix in 4098.2.diff​.

[boonebgorges]

(In [6094]) Use wp_get_theme() instead of current_theme_info() in bp_core_activation_notice()

current_theme_info() is the pre-WP-3.4 function. This reverts part of r6089.

See #4098

[boonebgorges]

I think we have caught all of these, so I'm closing.