Opened 13 years ago
Closed 12 years ago
#4098 closed defect (bug) (fixed)
WP 3.4 deprecated theme functions
Reported by: | boonebgorges | Owned by: | |
---|---|---|---|
Milestone: | 1.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
WP 3.4 deprecates several items currently in use by BP:
- Notice: add_custom_background is deprecated since version 3.4! Use add_theme_support( 'custom-background', $args ) instead. in /sites/ciab/wp-includes/functions.php on line 2708
- Notice: add_custom_image_header is deprecated since version 3.4! Use add_theme_support( 'custom-header', $args ) instead. in /sites/ciab/wp-includes/functions.php on line 2708
- get_themes() deprecated by wp_get_themes() during installation wizard
Attachments (5)
Change History (19)
#3
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Looks like a typo might have slipped into [5978]
Line 559 "$installad_themes" > "$installed_themes"
#7
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Still not quite done here. Both $ct and $ct->tags can be empty, which will dump a notice.
Should also do a function_exists() check instead of a version check.
#8
@
13 years ago
Also related:
[14-May-2012 21:28:27] PHP Warning: Illegal offset type in /Users/paul/Sites/master/wp-content/plugins/buddypress/bp-core/admin/bp-core-update.php on line 558
During install wizard, non-multisite.
#9
@
12 years ago
Updated patch with JJJ's suggestion, also improved custom header implementation, constants should be used for backward-compatibility.
As DJPaul said, $installed_themes[$current_theme]
will trigger the warning. Also not sure if installed themes array is needed at all.
This would be enough:
if ( !empty( $current_theme['Screenshot'] ) ) { $screenshot = trailingslashit( get_stylesheet_directory_uri() ) . $current_theme; }
#11
follow-up:
↓ 12
@
12 years ago
- Keywords needs-patch added; has-patch removed
Had a quick look at 4098.diff -- it uses $custom_background_args when its not set (in the not-3.4 if).
#12
in reply to:
↑ 11
@
12 years ago
- Keywords has-patch added; needs-patch removed
Replying to DJPaul:
Had a quick look at 4098.diff -- it uses $custom_background_args when its not set (in the not-3.4 if).
Sorry for that, quick fix in 4098.2.diff.
Notice: current_theme_info is deprecated since version 3.4! Use wp_get_theme() instead. bp-core-functions.php:242