Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#4094 closed defect (bug) (worksforme)

Doesn't remove slashes from emails when sending validation email

Reported by: holizz Owned by:
Priority: normal Milestone:
Component: Core Version:
Severity: normal Keywords: reporter-feedback
Cc:

Description

This means people with quotes in their email address can't sign up.

In function bp_core_signup_send_validation_email (bp-members/bp-members-signup.php:568).

I attach a patch that works, but perhaps $user_email should be un-slashed at some earlier point.

Attachments (1)

patch (495 bytes ) - added by holizz 14 years ago.

Download all attachments as: .zip

Change History (7)

@holizz
14 years ago

#1 @cnorris23
14 years ago

Good catch. I never knew quotes were even valid in the local part of an email address. Since this is the case, we should check other areas of the code to make sure they too, have their slashes stripped.

#2 @DJPaul
14 years ago

  • Milestone Awaiting Review1.6
  • Owner set to DJPaul
  • Status newassigned

#3 @DJPaul
14 years ago

  • Owner DJPaul removed

#4 @DJPaul
14 years ago

  • Keywords reporter-feedback added
  • Milestone 1.6Future Release

Can you supply a sample email address that I can use to recreate the problem? I can't get the email address in bp_core_signup_send_validation_email() to be slashed.

#5 @holizz
14 years ago

  • Resolutionworksforme
  • Status assignedclosed

I tried to reproduce this and couldn't, so I'll close it.

#6 @johnjamesjacoby
14 years ago

  • Milestone Future Release
Note: See TracTickets for help on using tickets.