Edit Member toolbar javascript still fires when clicking cancel

[johnjamesjacoby]

When you spam or delete a user via the Edit Member toolbar item, clicking cancel still performs the action. I elect we ditch the alert all together for more robust templates that give us more control over a users status and capabilities for later.

[johnjamesjacoby]

(In [5829]) First pass at adding user capabilities screen and action to settings component:

• Add capabilities template
• Unhook core spammer and deleted user actions and move to settings
• Route admin bar links appropriately to new locations
• Allow delete-account to be accessed by super admins in place of broken alerts
• Improve general settings feedback
• @todo - backpat post mortem
• See #4038

[johnjamesjacoby]

(In [5832]) Tweak general settings logic to include boolean for successfully changed email address. See #4038, #4010.

[johnjamesjacoby]

(In [5833]) Backport messages output filters from trunk. See #4010, #4038. (1.5 branch)

[DJPaul]

(We need to kept the javascript itself in the theme for compat with other places in BP-Default, as well as third-party plugins/themes that make use of it.)

[DJPaul]

JJJ, is this complete? The Toolbar's Edit Member button no longer uses the javascript, and the other confirm prompts that I can find (e.g. delete an activity item) function correctly.

[DJPaul]

I'm going to close this ticket as complete; the edit member toolbar javascript alert has been removed per r5829, and I can't find any more confirm(), with the exception of one in the Activity admin screen which I believe should stay.

Let's open new individual tickets if any more instances come up.