Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#4008 closed defect (bug) (fixed)

default settings are incorrect

Reported by: djpaul's profile DJPaul Owned by:
Milestone: 1.6 Priority: normal
Severity: blocker Version:
Component: Administration Keywords:
Cc:

Description

On a clean install of WP + BP (non-multisite), after completing the set up wizard, accepting the defaults, the settings panel shows some strange defaults. Previous versions of BP allow avatar upload and account deletion and group creation by default, so I'm calling this a bug.

Screenshot attached.

Attachments (5)

2012-02-13 07.46.34 pm.png (51.3 KB) - added by DJPaul 12 years ago.
4008-1.patch (6.7 KB) - added by DJPaul 12 years ago.
shanebp-1.png (38.4 KB) - added by shanebp 12 years ago.
shanebp-2.png (34.4 KB) - added by shanebp 12 years ago.
shanebp-3.png (33.5 KB) - added by shanebp 12 years ago.

Download all attachments as: .zip

Change History (26)

#1 @DJPaul
12 years ago

Our BP 1.5 option names as set in bp_get_default_options() are different from what is used in the settings screen markup in register_admin_settings(), of which the latter has a decidedly bbPress-inspired naming convention. Need to decide which to use, and handle any setting migration as necessary.

#2 @DJPaul
12 years ago

  • Keywords dev-feedback added

#3 @johnjamesjacoby
12 years ago

(In [5937]) Register correct setting name for Activity Akismet. See #4008.

#4 @johnjamesjacoby
12 years ago

Probably too late to go on an option renaming spree. Let's match them to their old (and incorrectly hyphenated) counterparts.

#5 @boonebgorges
12 years ago

Probably too late to go on an option renaming spree. Let's match them to their old (and incorrectly hyphenated) counterparts.

+1. Much easier for now.

#6 @DJPaul
12 years ago

  • Keywords dev-feedback removed

When this is done, the phpdoc for the Settings component needs an overhaul as there's a lot of copy/paste remnants from bbPress.

#7 @djpaul
12 years ago

(In [6026]) Remove a bunch of admin screen helper functions which came from bbPress. See #4008

#8 @djpaul
12 years ago

(In [6037]) Remove duplicate (and unused) db version string. See #4008

#9 @DJPaul
12 years ago

  • Severity changed from normal to major

@DJPaul
12 years ago

#10 @DJPaul
12 years ago

  • Keywords has-patch needs-testing added

Please would someone eyeball and test 4008-1.patch. You'll need to test upgrades from 1.5, with different combinations of settings turned on/off.

I've assumed that we want the settings labelled as they are in trunk, which is why I've put some logic in the upgrade_1_6() method to flip the values around.

#11 @djpaul
12 years ago

(In [6038]) Remove unused admin dashboard CSS which came from bbPress. See #4008

#12 @boonebgorges
12 years ago

I'll try to have a look at 4008-1.patch in the next few days.

#13 @shanebp
12 years ago

Switching back and forth from 1.5.5 to trunk-6058, everything looks fine here...

Here are 3 'Settings' screenshots in 1.6 after changing settings in 1.5.5:

shanebp-1.png: 1.5.5 defaults to 1.6

shanebp-2.png: 1.5.5 all off to 1.6

shanebp-3.png: 1.5.5 with avatar uploads and delete accounts set to 'No' to 1.6

I didn't have any forums enabled for any of these.

More testing? Better testing? Lemme know.

@shanebp
12 years ago

@shanebp
12 years ago

@shanebp
12 years ago

#14 @djpaul
12 years ago

(In [6066]) Remove some more copypasta that came from/belongs in bbPress. See #4008.

  • The 'Root forum ID for groups' belongs to bbPress.
  • Don't serialise 'bp-deactivated-components'.
  • Remove 'Use WP Editor' option until/if we decide to integrate TinyMCE into any BP component.

#15 @DJPaul
12 years ago

  • Keywords needs-testing removed

Thanks for testing shanebp

#16 @djpaul
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6067]) Correct BuddyPress core settings values when upgrading from 1.5 to 1.6. Fixes #4008

#17 @DJPaul
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

My last commit is all bad.

#18 @djpaul
12 years ago

(In [6078]) Revert part of r6067. See #4008, antiprops DJPaul

#19 @DJPaul
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#20 @DJPaul
12 years ago

  • Keywords has-patch removed
  • Resolution fixed deleted
  • Severity changed from major to blocker
  • Status changed from closed to reopened

This still isn't fixed. On a clean non-ms install, the following options are not ticked in the UI:

Account Deletion, Avatar Uploads, Group Creation

#21 @djpaul
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6145]) Fix default settings being set incorrectly on a clean install. Fixes #4008 again

Note: See TracTickets for help on using tickets.