Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

Last modified 10 years ago

#3989 closed enhancement (fixed)

$bp global clean-up

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.5.3
Component: Core Keywords:
Cc:

Description

Now that we have wrapper functions for most things, there are $bp globals littered through-out the code that are no longer necessary.

Change History (18)

#1 @johnjamesjacoby
14 years ago

Note when removing these globals, please also remove any associated phpdoc.

#2 @johnjamesjacoby
14 years ago

(In [5683]) Remove a bunch of unneeded globals and clean up some code in Core component. See #3989.

#3 @johnjamesjacoby
14 years ago

(In [5684]) Remove unneeded globals and clean up some code in Activity component. See #3989.

#4 @johnjamesjacoby
14 years ago

(In [5686]) Remove unneeded globals and clean up some code in Blogs component. See #3989.

#5 @johnjamesjacoby
14 years ago

(In [5687]) Audit the usage of $bp->is_item_admin and $bp->is_item_mod to use the _is_ functions isntead. Also fix some $bp globals in the process. See #3989.

#6 @johnjamesjacoby
14 years ago

(In [5689]) Remove unneeded globals and clean up some code in Groups component. See #3989.

#7 @johnjamesjacoby
14 years ago

(In [5690]) Remove unneeded globals and clean up some code in Settings component. See #3989.

#8 @johnjamesjacoby
14 years ago

(In [5696]) Remove unneeded globals and clean up some code in Messages component. See #3989.

#9 @johnjamesjacoby
14 years ago

(In [5699]) Remove unneeded globals and clean up some code in XProfile component. See #3989.

#10 @johnjamesjacoby
14 years ago

(In [5700]) Remove unneeded globals and clean up some code in Members component. Remove signup file and move its code into screens and functions. See #3989.

#11 @johnjamesjacoby
14 years ago

(In [5701]) Fix typo in phpdoc in messages actions header. See #3989.

#12 @johnjamesjacoby
14 years ago

(In [5702]) Actually fix typo in phpdoc in messages actions header. See #3989. Antiprops johnjamesjacoby.

#13 @johnjamesjacoby
14 years ago

(In [5705]) Replace direct references to $bp user fullname and user_login with their functional equivalents, and kill off some $bp global usage in the process. See #3994, #3989.

#14 @johnjamesjacoby
14 years ago

(In [5706]) Remove unused $bp globals from bp-default's ajax.php. See #3989.

#15 @johnjamesjacoby
14 years ago

(In [5712]) Remove unneeded globals and clean up some code in Friends component. See #3989.

#16 @johnjamesjacoby
14 years ago

(In [5714]) Remove unneeded globals and clean up some code in Groups component. See #3989.

#17 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

The majority of this is done. Closing as fixed. Feel free to snipe these on an on-going basis.

#18 @DJPaul
10 years ago

  • Type changed from task to enhancement
Note: See TracTickets for help on using tickets.