Opened 13 years ago
Closed 8 years ago
#3935 closed defect (bug) (wontfix)
Members directory does not generate correct HTML (form inside form)
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 1.5.3 |
Component: | Templates | Keywords: | needs-patch |
Cc: | rcain@… |
Description
The search form nested inside the form for the members directory is not valid XHTML / HTML5 (forms can't be nested in forms).
As a result browsers terminate the members directory form after the search form, and not at the bottom of the members directory (as intended).
To fix: the search form (generated by bp_directory_members_search_form() function) should be moved outside of the form#members-directory-form
Note though: this introduces additional problems that should be fixed - i.e. the search of members works, but the search is also picked up by WP and an additional archive search performed.
Change History (9)
#2
@
13 years ago
- Component changed from Core to Theme
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 1.6
Bit worried about backpat if we move this.
#3
@
13 years ago
- Milestone changed from 1.6 to Future Release
Agree this is bad form, but we're stuck with it for now. Moving to Future Release until we can decouple these forms.
#4
@
12 years ago
- Cc rcain@… added
- Version changed from 1.5.3 to 1.6.1
Hi, did this ever get fixed please?
Is causing me a few headaches with base bp functionality + bad plugin behaviour around this point in code.
Am using wp 3.4.2 + bp 1.6.1.
Thanks.
#9
@
8 years ago
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from new to closed
This isn't a problem in the currently used bp-legacy "theme" (see: https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/index.php) and since bp-default isn't supported anymore (see: https://bpdevel.wordpress.com/2013/11/13/the-future-of-the-bp-default-theme/) I'm closing this as wontfix.
please ignore last paragraph about archive search - that's not related to this problem