Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 3 years ago

#3903 closed defect (bug) (wontfix)

js for showing #whats-new-options on textarea focus has wrong value

Reported by: dcavins's profile dcavins Owned by:
Milestone: Priority: normal
Severity: minor Version: 1.5.2
Component: Templates Keywords: close
Cc:

Description

In this bit of global.js:

/* Textarea focus */

jq('#whats-new').focus( function(){

jq("#whats-new-options").animate({height:'40px'});
jq("form#whats-new-form textarea").animate({height:'50px'});
jq("#aw-whats-new-submit").prop("disabled", false);

});

The .animate({height:'40px'}); value needs to be more like 60px. I'm on a Mac, and if the submit button and the "Post in" drop-down both need to show, 40px is too short. See attached image.

Attachments (1)

what-new-options.png (5.2 KB) - added by dcavins 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 follow-up: @r-a-y
12 years ago

The JS is applicable to the bp-default theme.

Are you using a custom theme? Or are you using bp-default on a mobile device by chance?

#2 in reply to: ↑ 1 @dcavins
12 years ago

  • Severity changed from normal to minor

Replying to r-a-y:

The JS is applicable to the bp-default theme.

Are you using a custom theme? Or are you using bp-default on a mobile device by chance?

I'm using a TwentyEleven child theme install. I haven't had to modify the bp-default theming—it works really well out-of-the-box. Using Firebug, I can verify that the css for all the elements, including text size, in this area is coming from bp-default.

This is on a desktop browser.

BTW, I'm amazed at how well WP/BP+child theming work together.

#3 @r-a-y
12 years ago

  • Keywords close added

Since this issue is applicable to your TwentyEleven child theme, I'd recommend rolling your own JS and using unbind().

Then you could set your own dimensions for the "What's New" auto-expander.

#4 follow-up: @DJPaul
12 years ago

  • Component changed from Core to Theme
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

At the end of the day, BP-Default's javascript is built for BP-Default. You're going to have to customise this in your theme; r-a-y suggests one approach. We're working towards not having so much useful stuff in the core theme, i.e. we might do something like a common javascript file.

#5 in reply to: ↑ 4 @dcavins
12 years ago

Replying to DJPaul:

At the end of the day, BP-Default's javascript is built for BP-Default. You're going to have to customise this in your theme; r-a-y suggests one approach. We're working towards not having so much useful stuff in the core theme, i.e. we might do something like a common javascript file.

I think your future plan is a good one; splitting some of the pieces out so BP isn't so monolithic would make it easier to customize.
Thanks!

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.