Skip to:
Content

Opened 6 years ago

Closed 3 months ago

Last modified 3 months ago

#3889 closed enhancement (fixed)

When searching on the activity page, you cannot search using an authors name.

Reported by: fanquake Owned by: djpaul
Milestone: 3.0 Priority: normal
Severity: minor Version:
Component: Activity Keywords: has-patch needs-unit-tests
Cc:

Description

When using the search form on the Activity page, if you search for the name of the author of an activity item, nothing is returned. This functionality should included, then I think that it should be, as then you would be able to search for repeat offenders by name etc.

Attachments (1)

3889-user-searching.diff (1.1 KB) - added by tw2113 12 months ago.

Download all attachments as: .zip

Change History (16)

#1 in reply to: ↑ description @fanquake
6 years ago

Replying to fanquake:

When using the search form on the Activity page, if you search for the name of the author of an activity item, nothing is returned. This functionality should be included, as then you would be able to search for repeat offenders by name etc.

#2 @DJPaul
6 years ago

Admin or front end?

#3 @fanquake
6 years ago

Admin

#4 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

Right now we use the activity loop search parameter, which doesn't search on username. Will have to take a look at how best to do this in a future release.

#5 @boonebgorges
5 years ago

  • Keywords needs-patch added
  • Severity changed from normal to minor

#6 @tw2113
12 months ago

Big conflict with adding username searching is that BuddyPress doesn't store user information as username. It's by user ID.

Perhaps, we could do a boolean based filter to conditionally search users. Basically, if the filter returns true, we do a user lookup by username. If we find a valid user, then we add the sql clause for also searching for the ID column based on the found user's ID.

See diff attached.

#7 @tw2113
12 months ago

  • Keywords has-patch 2nd-opinion needs-testing added; needs-patch removed

#8 @tw2113
12 months ago

  • Milestone changed from Future Release to 2.9

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


11 months ago

#10 @tw2113
11 months ago

  • Keywords needs-unit-tests added
  • Milestone changed from 2.9 to Future Release

#11 @DJPaul
4 months ago

  • Milestone changed from Future Release to 3.0

Moving this to 3.0 so we decide if we want to do this or not, and how.

#12 @DJPaul
4 months ago

  • Milestone changed from 3.0 to Under Consideration

#13 @DJPaul
3 months ago

  • Keywords 2nd-opinion needs-testing removed
  • Milestone changed from Under Consideration to 3.0

Disappointing to have no received feedback on this in the last 6 weeks.

Given the fact this behaviour would be toggled by a filter rather than it being some sort of new UI functionality, let's just get it in.

#14 @djpaul
3 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11867:

Activity: support searching by author slug.

Non-user facing change. Requires a filter to be applied.

Fixes #3889

Props tw2113

#15 @tw2113
3 months ago

Paul, should probably get the @ since tag reflective of 3.0, otherwise :D

Note: See TracTickets for help on using tickets.