Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 8 years ago

#3877 closed enhancement (no action required)

Always load bp_get_options_nav() in members/single/profile.php

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords:
Cc:

Description

In the profile component, we only show the options_nav if bp_is_my_profile(). http://buddypress.trac.wordpress.org/browser/tags/1.5.2/bp-themes/bp-default/members/single/profile.php#L12

I get the reasoning behind this - you'll never need the Edit or Change Avatar item on profiles other than your own. But it limits extensibility for developers. See eg http://buddypress.org/community/groups/creating-extending/forum/topic/bp_core_new_subnav_item-wont-create-item-under-profile-section/ Moreover, xprofile is the only component where we do this, which makes development inconsistent.

If we're concerned about the wasted screen real estate in showing a subnav that only has a single item ('Public'), then perhaps we could replace the bp_is_my_profile() check with a different kind of (optional) check, which only displays the subnav when there's more than one item. Regardless of whether we do something like this, I think it's a good idea to remove the bp_is_my_profile() check (and double check that the Edit and Change Avatar items are only visible to the current user/super admin, which I'm pretty sure they already are).

Change History (1)

#1 @DJPaul
8 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

No idea when this changed, but this is how it works in BP-Legacy already.

Note: See TracTickets for help on using tickets.