Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#3822 closed enhancement (fixed)

Improve activity admin status messages

Reported by: fanquake Owned by: DJPaul
Milestone: 1.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Cc:

Description

When marking and item as "Not Spam" from the drop down, you get the error "An error occured when updating Activity ID #XXX."

Small side note here, occurred is spelt wrong..

Change History (11)

#1 @fanquake
10 years ago

  • Summary changed from Marking an item as "Not Spam" create as an error to Marking an item as "Not Spam" creates an error

#2 @DJPaul
10 years ago

Thanks, fixed the typo in a commit about to go into #3660. Also on this new version, I can't recreate this bug. Can you svn up and try to recreate it?

#3 @djpaul
10 years ago

(In [5484]) Activity admin iteration. See #3660.

  • Add remaining activity properties to the edit screen.
  • Add new contextual help to the edit screen.
  • Add support for 2 columns to the edit screen.
  • Fix a typo (props fanquake, see #3822).
  • Update BP_Activity_Activity::save() method to fix a bug where an update operation with no changes was reported as an error.
  • Update activity admin CSS, bump version number.

#4 @DJPaul
10 years ago

  • Keywords reporter-feedback added

#5 @fanquake
10 years ago

  • Keywords reporter-feedback removed
  • Resolution set to fixed
  • Status changed from new to closed

I can no longer reproduce, so it must have been fixed.

#6 @fanquake
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Was going to create a new ticket, but this is related. When you mark an item as not spam, you see the message "1 activity restored from the spam." Should this be changed to "1 activity item restored from the spam." ?

#7 @johnjamesjacoby
10 years ago

"%d activity items successfully unspammed"

or

"%d activity items successfully rescued from the spam abyss" works too

#8 @DJPaul
10 years ago

I don't like abysses. With that said, are we going for "activities" or "activity items" for >1? Need to change all of the status messages at the top of bp_activity_admin_index() for consistency if this one changes.

#9 @johnjamesjacoby
10 years ago

"Activity items" please.

#10 @DJPaul
10 years ago

  • Component changed from Core to Administration
  • Milestone changed from Awaiting Review to 1.6
  • Owner set to DJPaul
  • Status changed from reopened to assigned
  • Summary changed from Marking an item as "Not Spam" creates an error to Improve activity admin status messages
  • Type changed from defect (bug) to enhancement

#11 @djpaul
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5553]) Tweak activity admin status strings. Fixes #3822

Note: See TracTickets for help on using tickets.