Template handling error when accessing member's profile edit URL

[DJPaul]

When logged out, when accessing a valid user's edit profile URL, rather than 404 or redirect (whichever is the correct behaviour for here), you get a weird partial template rendered.

Tested on ​http://testbp.org/members/djpaul/profile/edit/group/1 but not on a local copy.

[boonebgorges]

Strange. On my local, I get a 404. (Probably should be a no-access-redirect, but a 404 is good enough.) Needs more testing.

[johnjamesjacoby]

That's bbPress 2.0 taking over. Assigning to myself to look at for 1.6.

[johnjamesjacoby]

(In [5763]) Add an is_404() check to bp_is_user() to prevent partial matches from returning true. Fixes #3815.

[r-a-y]

r5763 breaks BP RSS feeds from displaying properly due to the is_404() check.

• bp_is_user_activity() is used on all BP RSS action router functions to determine if we're currently on a BP user activity page.
• bp_is_user() is used by bp_is_user_activity()

Since BP RSS feeds are 404 by default, the bp_is_user_activity() check will fail and the RSS feeds will not render properly.

Try out any of the following:

• /members/admin/activity/friends/feed/
• /members/admin/activity/groups/feed/
• /members/admin/activity/mentions/feed/
• /members/admin/activity/favorites/feed/

When I revert r5763, I can no longer duplicate DJPaul's initial report.

My recommendation is to revert r5763 and I'd like to fix this for 1.7.1.

[boonebgorges]

See also #4329

I agree that the best thing to do here is revert r5763.

[johnjamesjacoby]

In 6947:

Revert r5763 as it introduced a regression in bp_is_user() behavior. See #3815.

[johnjamesjacoby]

Can't duplicate anymore either, so marking as resolved.

[r-a-y]

In 6966:

Revert r5763 as it introduced a regression in bp_is_user() behavior.

See #3815 (1.7-branch).