bp_message_get_recipient_tabs() uses bp_core_get_userid() instead of bp_core_get_userid_from_nicename()

[r-a-y]

By default, BuddyPress now checks for user_nicename instead of user_login, however we don't check for user_nicename in bp_core_get_userid().

So far, I've found this breaks autocomplete functionality for the messages component if the user_login does not match the user_nicename. (For the most part, this occurs on single WordPress installs that are adding BuddyPress for the first time.) But there could be more instances.

A code audit of user_login vs. user_nicename should probably be done at the same time as well.

[r-a-y]

Okay, just did some investigating.

Turns out there is a function that grabs the user_id by user_nicename - bp_core_get_userid_from_nicename().

We should use that function combined with bp_is_username_compatibility_mode() in bp_message_get_recipient_tabs().

Changing the ticket title appropriately.

[r-a-y]

Would like to see this set for the v1.5.2 milestone if possible.

[boonebgorges]

This seems fine for 1.5.2.

[boonebgorges]

(In [5532]) Use the proper function for getting userid in bp_message_get_recipient_tabs(), depending on configuration. Fixes #3800. Props r-a-y

[boonebgorges]

(In [5533]) Use the proper function for getting userid in bp_message_get_recipient_tabs(), depending on configuration. Fixes #3800. Props r-a-y