Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3785 closed defect (bug) (fixed)

Settings subpanel should be network aware

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.6 Priority: normal
Severity: major Version:
Component: Toolbar & Notifications Keywords:


When running MS, the Settings panel is not added to the right place. Most BP settings (on non-multiblog mode) are networkwide, and the settings page should be put under Network Admin accordingly.

Related, the link on the Help subtab auto-added when a plugin creates a subpanel goes to a non-existent page in MS.

Attachments (2)

3875-1.patch (2.0 KB) - added by DJPaul 13 years ago.
3785-2.patch (3.6 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (8)

13 years ago

#1 @DJPaul
13 years ago

  • Keywords needs-testing has-patch added

I've attached a patch which seems to fix the issue, but I'd appreciate someone else to test it before it goes in.

#2 @boonebgorges
13 years ago

3875-2.patch fixes the link on the Help landing page. Otherwise looks good. (Looks like the current-page highlighting is not working right, at least on Network Admin. Not sure if that's an MS-specific problem. Also, is it intentional that Forum Setup doesn't get a top-level page?)

#3 @DJPaul
13 years ago

Only one of those pages were meant to appear under Settings. I've fixed that. Tested on MS and regular, and everything looks consistent. Current-page highlighting is also working for me (now, at least). Leaving ticket open for feedback/testing.

#4 @djpaul
13 years ago

(In [5429]) Multisite fixes for the relocated admin menu. See #3785, props boonebgorges for help with patch

#5 @boonebgorges
13 years ago

  • Keywords needs-testing has-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Looks good to me. Thanks, Paul.

#6 @DJPaul
8 years ago

  • Component changed from General - Toolbar/BuddyBar to Toolbar & Notifications
Note: See TracTickets for help on using tickets.