Can't activate bp-default

[boonebgorges]

I can't activate the current rev of bp-default r5394 on the trunk. I get a 'Current theme is broken' error, and I'm reverted to the default theme. Works OK on the 1.5 branch, so if I switch over, activate, then switch back, everything's OK.

[boonebgorges]

On further examination, it looks like the problem arises from the fact that the bp-themes directory is being registered with WP using a path generated by plugin_dir_path(), and my installation is set up in such a way that plugin_dir_path() is broken. See ​#WP16953.

[boonebgorges]

As jjj noted in IRC, this will affect IIS installations as well. Bumping priority accordingly.

See also ​https://bugs.php.net/bug.php?id=46260, groan.

[boonebgorges]

In r5405 I fixed BuddyPress::setup_globals() so that, at the very least, BP_PLUGIN_DIR and BP_PLUGIN_URL are respected. With this in place, I can activate bp-default by manually defining BP_PLUGIN_URL in my wp-config.php file. This is not acceptable as a permanent workaround, but at least it lets me carry on with development :)

[boonebgorges]

3772.01.patch is my suggested fix. It essentially reverts to the current method for setting BP_PLUGIN_DIR.

[hnla]

Is this just a problem with upgrading sites then? as it's reported to me that new install appears to work ok but I don't have detail on that - but will test when have a spare moment.

[boonebgorges]

Fixed in r5566.