Opened 13 years ago
Last modified 8 years ago
#3727 new defect (bug)
group extension admin page can't be configured to be accessed by group mods
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Contributions | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Groups | Keywords: | |
| Cc: |
Description
When adding a group extension, and an tab in the admin nav has been added, the check in bp_group_admin_tabs() doesn't add your new tab if you are are a group moderator (or even a member, for that matter).
The visibility logic makes much more sense to do the check in the template, or when the menus are added. However there are backpat issues to handle which makes this tricky
Note: See
TracTickets for help on using
tickets.
Looking at #4737 and r9127 (where the group extension api was added to this function) It seems that this is the desired behaviour I think. Only admins should be able to access and edit administrative pages under "manage". This is also what is described in the codex: https://codex.buddypress.org/administrator-guide/group-settings-and-roles/
Since this ticket was created the admin check has also switched from $bp->is_item_admin to bp_is_item_admin() which is filterable so it should be possible to make a moderator be able to see this tab.
I'm not 100% sure though if that was what you where after when creating this ticket eons ago @DJPaul but I think that this could be closed... What do you say? :)