Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3712 closed defect (bug) (fixed)

Fatal Error: function bp_get_settings_slug undefined

Reported by: hnla Owned by:
Milestone: 1.6 Priority: normal
Severity: major Version: 1.5
Component: Core Keywords: needs-patch
Cc:

Description

If you disable Account Settings in BP components then navigate to a group and attempt to promote a member a fatal error is thrown:
Call to undefined function bp_get_settings_slug() in /html/wp-content/plugins/buddypress/bp-groups/bp-groups-notifications.php on line 172

Tested this back and fourth and can confirm enabling Account Settings again clears the issue.

Feels as though a if(function_exists()) is required?

I haven't time to break work flow right now to try out a patch but will tomorrow if necessary.

Change History (5)

#1 @r-a-y
8 years ago

At the moment, I think "Account settings" should be mandatory because notifications in various components require it.

Maybe notifications should be split up into its own component, so it isn't so tied to settings.

#2 @johnjamesjacoby
8 years ago

Notifications could definitely be it's own component, and probably should/will be in a future version.

#3 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5296]) Add function_exists checks for bp_get_settings_slug() where needed. Fixes #3712.

#4 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 1.6

#5 @boonebgorges
8 years ago

(In [5801]) Adds function_exists() checks for settings links.
A port of r5296 to the 1.5 branch.
Fixes #3996. See #3712. Props johnjamesjacoby

Note: See TracTickets for help on using tickets.