Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3691 closed defect (bug) (fixed)

Fatal call to bp_activity_get_permalink() if activity updates have been used but subsequently disabled

Reported by: boonebgorges Owned by:
Milestone: 1.5.2 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-patch
Cc:

Description

In the members loop (and maybe elsewhere), bp_get_member_latest_update() tries to show the latest update. We bail out of that function if the member's latest_update field is empty, which it will be if activity was never enabled. However, that field may be populated if activity *was* once enabled, which means that we won't bail, and we hit a fatal error later in the function with bp_activity_get_permalink().

There are probably fancy ways to fix this, but I suggest a simple bp_is_active() check. See 01.patch.

Attachments (1)

3691.01.diff (891 bytes) - added by boonebgorges 8 years ago.

Download all attachments as: .zip

Change History (4)

@boonebgorges
8 years ago

#1 @johnjamesjacoby
8 years ago

Looks good to me.

#2 @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5270]) Don't try to get activity permalink in bp_get_member_last_update() if activity component is disabled. Fixes #3691.

#3 @boonebgorges
8 years ago

(In [5271]) Don't try to get activity permalink in bp_get_member_last_update() if activity component is disabled. Fixes #3691.

Note: See TracTickets for help on using tickets.