Multiple loops and pagination variable collision

[r-a-y]

If you attempt to use multiple loops of the same component with pagination, the loops will not be independent of one another.

One way to work around this is to introduce a new parameter that we can set in the loop.

Then, the constructor that populates the loop will use this parameter as the query arg in pagination_links().

I've attached a patch detailing how this might work with the members loop.

The hope is that this approach will be used for all BP loops.

[r-a-y]

So if you use a default members loop and you want another loop independent of the current one, you could use something like:

<?php if ( bp_has_members( 'page_arg=members&per_page=5' ) ) : ?>

[cnorris23]

Does using bp_rewind_members() after the first loop not work either?

[cnorris23]

Nevermind. I just looked closer. bp_rewind_members() wouldn't do anything for this.

[DJPaul]

Looks good, go ahead and patch for the other loops, please. Only thing I'd change is adding a default value to that new class constructor argument, for backpat.

[boonebgorges]

The approach in this patch is fine, but we do need a refresh that will give a default value, as DJPaul suggested. r-a-y, can you do that for us? Can still squeeze this into 1.6, as there shouldn't be any other backpat issues and it's a straightforward enhancement.

[johnjamesjacoby]

It's getting late to squeeze this in for 1.6. It'd be great to do the same for all of the loops, not just members. Groups, Activity, etc...

Moving to Future Release; feel free to patch and move back to 1.6. Boone/Paul - if a good patch comes around, commit it asap so we can test it out.

[cnorris23]

Activity

[cnorris23]

Blogs

[cnorris23]

Groups

[cnorris23]

Members

[cnorris23]

Messages

[cnorris23]

Refreshed original patch, and patched other loops with pagination, with forums being the exception. I went a la carte to so one can craft their ideal pagination variable collision prevention scenario.

I also noticed that in the template classes, we're inconsistent with PHP 4 contructors, or lack thereof. Three of the five I patched have PHP 4 constructors. Are these still needed, or should we start cleaning them out?

[DJPaul]

Thanks for the patches. And yes, we're removing the PHP4 constructors.

[djpaul]

(In [5891]) Allow pagination arguments for template loops to be renamed. Remove PHP4 constructors. Fixes #3679, props r-a-y and cnorris23