bb-config-location should default to something intelligent

[boonebgorges]

I recently worked with someone who, for some unexplained reason, kept having her 'bb-config-location' option deleted, which resulted in bp_forums_is_installed_correctly() returning false. I'm not sure why the bb-config-location option keeps getting deleted - probably a plugin conflict (I couldn't reproduce it on a clean install). But, in any case, it would have continued to work even in the absence of bb-config-location if the default value for that option, as set in bp_core_get_root_options(), were something sensible: ABSPATH . 'bb-config.php' instead of ABSPATH. And since we do an is_file() check before actually loading that value into the $bp->forums object, there's no chance of false positives.

Objections?

[DJPaul]

Good idea

[boonebgorges]

(In [5239]) Makes bb-config-location default to a meaningful path, to better cover edge cases where the bb-config-location option is missing. Fixes #3677

[boonebgorges]

(In [5240]) Makes bb-config-location default to a meaningful path, to better cover edge cases where the bb-config-location option is missing. Fixes #3677