Spammers can post forum topics

[DJPaul]

It's possible for users marked as spammers to create new forum topics and replies.

[DJPaul]

Attached patch has been tested, but I haven't committed it as I'm not sure if these should be done higher up the chain someplace.

[boonebgorges]

As we discussed yesterday, I think that in a perfect world we would check this all the way at the top of the chain (or bottom, depending on your point of view) - right in the WPDB query class. There is a filter right at the beginning of WPDB:query() that would allow us to do something like the following (not tested of course):

function bp_block_spammers( $query ) {
  if ( bp_core_is_user_spammer( bp_loggedin_user_id() ) && ( 0 === strpos( $query, 'UPDATE' ) || 0 === strpos( $query, 'INSERT' ) ) ) {
    $query = '';
  }
  return $query;
}
add_filter( 'query', 'bp_block_spammers', 999 );

I don't think we should be doing anything like this in the short term (or maybe ever, I would have to think about it :) ) but points toward a more general solution to the spammer issue. Also, we'd probably need to do it separately for bbPress 1.0 queries.

Anyway, suzuka-1.patch looks good to me for now. I say go with it.

[DJPaul]

I think we should implement/test the semi-bozo idea which was discussed the other week before we put in these bail-out patches

[DJPaul]

John's put most of this in; r5243 (trunk), r5244 (1.5 branch).

[djpaul]

(In [5245]) Fix admins being unable to edit topics made by users who have since been marked as spammers. Fixes #3667

[djpaul]

(In [5246]) Fix admins being unable to edit topics made by users who have since been marked as spammers. Fixes #3667