Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3636 closed defect (bug) (fixed)

Site Directory Site Number Span Redirects

Reported by: thecorkboard's profile thecorkboard Owned by:
Milestone: 1.5.1 Priority: normal
Severity: minor Version:
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

Sorry for the bad title...

The span which holds the amount of sites in the site directory causes a redirect to a 404 page when clicked on. Experienced using BP-Default and using a BP Template Pack-enhanced child theme.

Attachments (2)

Google Chrome.png (10.6 KB) - added by thecorkboard 13 years ago.
Screenshot
3636.01.patch (1.5 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (8)

@thecorkboard
13 years ago

Screenshot

#1 @boonebgorges
13 years ago

  • Milestone changed from Awaiting Review to 1.5.1

Confirmed. Also, odd. Putting under 1.5.1 pending a patch.

#2 @boonebgorges
13 years ago

  • Keywords has-patch dev-feedback added

The fix is in 3636.01.patch. The tabs both had the incorrect paths. Both are old, old errors, from way back in the 1.2 branch.

Posting here as a patch because I'm not certain whether we have a policy on making changes to templates mid-cycle. My feeling is that this is a non-destructive change (it's already broken for existing themes/bp-template-pack users), so it won't hurt anything. But I want feedback from another core dev on that.

#3 @johnjamesjacoby
13 years ago

If it's broken, fixing the theme is fine. One of the benefits of using bp-default as intended is that child themes get the fix for free.

#4 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5195]) Fixes 'All Sites' and 'My Sites' tab links on Sites directory. Fixes #3636

#5 @boonebgorges
13 years ago

(In [5196]) Fixes 'All Sites' and 'My Sites' tab links on Sites directory. Fixes #3636

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.