Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3610 closed defect (bug) (fixed)

bp_groups_auto_join() defaults to false, should be true?

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.5.1 Priority: normal
Severity: major Version: 1.5
Component: Groups Keywords: dev-feedback has-patch
Cc:

Description

Is bp_groups_auto_join() supposed to default to true?

(I believe it was true in BP 1.2.x.) Because it currently defaults to false:
​http://buddypress.trac.wordpress.org/browser/tags/1.5/bp-groups/bp-groups-loader.php#L218

When it defaults to false, this causes some issues with the "Add a reply" form on group topic pages.

Attachments (2)

3610.01.patch​ (2.1 KB) - added by r-a-y 13 years ago.
3610.02.patch​ (2.8 KB) - added by r-a-y 13 years ago.

Download all attachments as: .zip

Change History (8)

@r-a-y
13 years ago

@r-a-y
13 years ago

#1 @r-a-y
13 years ago

02.patch adds a check to see if a user is logged in. If logged-in, display the "New Reply" link in the subnav on topic pages.

#2 @boonebgorges
13 years ago

  • Milestone changed from Awaiting Review to 1.5.1

Good catch. The auto join logic was messed up in r3917.

#3 @boonebgorges
13 years ago

(In [5181]) Ensures that bp_groups_auto_join() defaults to false; switches global check with bp_groups_auto_join() check. See #3610. Props r-a-y

#4 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5182]) Don't let non-logged-in users see the New Topic and New Reply subnav items in group forums. Fixes #3610. Props r-a-y

#5 @boonebgorges
13 years ago

(In [5183]) Ensures that bp_groups_auto_join() defaults to false; switches global check with bp_groups_auto_join() check. See #3610. Props r-a-y

#6 @boonebgorges
13 years ago

(In [5184]) Don't let non-logged-in users see the New Topic and New Reply subnav items in group forums. Fixes #3610. Props r-a-y

Note: See TracTickets for help on using tickets.