Call to undefined bbPress function bb_update_forum() when site forum enabled

[boonebgorges]

From etiviti via Twitter (he can't make his trac login work):

"Call to undefined function bb_update_forum() - updating group name w/no installed group forums but sitewide"

This suggests that the group's "enable discussion forum" is checked, which shouldn't be the case if group forums aren't available. Haven't verified this yet, but it should be checked.

[DJPaul]

I do not believe this is related to bbPress 2.0.

To recreate, install bbPress 1.x via BuddyPress. Create a group, or edit an existing group, to enable forums. Edit group title, it works fine. Disable bbPress 1.x via BuddyPress ("uninstall" on the forums wp-admin page), then go back to a group, and try editing the group title. This triggers the error.

Toggling bbPress 2.0 activate/inactive didn't seem to make a difference.

[boonebgorges]

Gotcha. Sounds like we should be checking for more than whether the group has enable_forum checked, but should also be checking for the actual presence of bbPress.

Did you happen to get a stack trace, so I don't have to dig through the code too much? I can check it out later otherwise.

[DJPaul]

Here's a messy list for you:

bb_update_forum() (line 68)
bp_forums_update_forum()(bp-groups-forums.php:40);
groups_update_group_forum()(:);
call_user_func_array()(plugin.php:405);
do_action()(bp-groups-functions.php:131);
groups_edit_base_group_details()(bp-groups-screens.php:481);
groups_screen_group_admin_edit_details()(:);
call_user_func_array()(plugin.php:405);
do_action()(bp-core-hooks.php:111);
bp_screens()(:);
call_user_func_array()(plugin.php:486);
do_action_ref_array()(class-wp.php:504);
main()(functions.php:1567);
wp()(wp-blog-header.php:14);
require()(index.php:17);

[boonebgorges]

Thanks, Paul! We are already doing a check in groups_update_group_forum(), but something must be up with the way that bp_is_active() is working in this case. We can probably add a function_exists() check to groups_update_group_forum() to solve the problem in any case. Will patch when I get a chance unless someone beats me to it.

[boonebgorges]

(In [5191]) Ensure that integrated bbPress forums have not been uninstalled before updating forum data on group edit. Fixes #3605

[boonebgorges]

(In [5192]) Ensure that integrated bbPress forums have not been uninstalled before updating forum data on group edit. Fixes #3605