Backpat with 3rd party plugins and is_site_admin()

[DJPaul]

Our backpat version of is_site_admin() was removed from 1.5 (it was in 1.2). While core doesn't use this deprecated function, some BuddyPress plugins do. The removal of this function is therefore causing PHP Errors. We should consider adding is_site_admin() back into bp-wp-abstraction.php, or contacting developers to tell them to update, or even consider seeing if we can update unsupported plugins on behalf of the original authors:

1) I've seen a few forum threads about this, but I'm not sure which plugins are the culprits.
2) WordPress only loads is_site_admin() in multisite, so the issue affects non-multisite only.
3) Plugin authors shouldn't be using is_site_admin(), so I'm guessing there are out-of-date plugins around.

I think we should build a list from the forums with people reporting this problem to investigate.

[DJPaul]

BP Group Tags is one:
http://buddypress.org/community/groups/buddypress-group-tags/forum/topic/group-category-blank-and-fatal-error-on-clicking-tag/

[westi]

IMHO you should never remove just deprecate - just like WP does.

[DJPaul]

Replying to westi:

IMHO you should never remove just deprecate - just like WP does.

Agreed; I think it was probably just an accident, and unfortunately we didn't spot it in the betas.

[boonebgorges]

(In [5173]) Properly deprecate is_site_admin(). Fixes #3603

[boonebgorges]

(In [5174]) Properly deprecate is_site_admin(). Fixes #3603

[boonebgorges]

(In [5175]) Wraps is_site_admin() deprecated function in function_exists(). Oops. See #3603

[boonebgorges]

(In [5176]) Wraps is_site_admin() deprecated function in function_exists(). Oops. See #3603