Skip to:
Content

Opened 3 years ago

Closed 2 years ago

#3596 closed defect (bug) (fixed)

Update to WP 3.3 admin bar

Reported by: boonebgorges Owned by:
Milestone: 1.6 Priority: major
Severity: major Version: 1.5
Component: Toolbar/BuddyBar Keywords:
Cc:

Description

The WP Admin Bar has changed in WP 3.3, so that our implementation is messed up in a couple of ways. At a glance:

  • current user menu, which has been shifted to the right, is now styled differently, so that our inline avatar looks bad
  • WP's default "thisblog" menu is not being removed properly
  • Order is messed up. We might want to think about right-justifying Notifications, since it's closely aligned conceptually with the logged-in user menu.

Attachments (2)

3596.01.patch (2.1 KB) - added by boonebgorges 2 years ago.
ticket.3596.diff (461 bytes) - added by ptahdunbar 2 years ago.
Add the My Account label back

Download all attachments as: .zip

Change History (13)

comment:1 boonebgorges3 years ago

(In [5211]) Updates user admin bar menu for right-floating compatibility in WP 3.3. See #3596

comment:2 boonebgorges3 years ago

(In [5212]) WP 3.3-specific unhooking of core admin bar menus. See #3596

comment:3 boonebgorges3 years ago

(In [5213]) Rehooks main WP admin bar items to core admin_bar_menu hook, so that we have greater control over the way our menus are ordered with respect to WP core menus. See #3596

comment:4 johnjamesjacoby3 years ago

Probably a bit early to put menu edits into trunk, as WP core menus are still being worked on. Right now BP trunk menus are really broken in both WP 3.2 branch and trunk.

Don't revert, but keep an eye on them and fix them up when you can.

I think we should not totally unhook the core menu, but instead add our sub menus below the core user avatar area, or maybe come up with some designs on where we want to hook the social menu into the existing core one.

comment:5 boonebgorges3 years ago

Probably a bit early to put menu edits into trunk, as WP core menus are still being worked on.

Fair enough.

Right now BP trunk menus are really broken in both WP 3.2 branch and trunk.

Quite broken on WP trunk; a bit out of order on WP 3.2.x.

I think we should not totally unhook the core menu

I agree. I was just starting with the strategy already in BP, which unhooks it entirely. I like the way that WP's trunk menu looks, so it probably makes sense to migrate to it.

comment:6 boonebgorges2 years ago

3596.01.patch is a suggestion for how to render the logged-in member dropdown. It's a bit bland. Suggestions welcome. Note: I haven't checked those changes against WP 3.2.

boonebgorges2 years ago

comment:7 johnjamesjacoby2 years ago

(In [5289]) First pass at updating the admin/toolbar for WordPress 3.3. See #3596.

comment:8 johnjamesjacoby2 years ago

(In [5290]) Fix incorrect background color issue with notifications menu when no notifications exist. See #3596.

comment:9 johnjamesjacoby2 years ago

(In [5291]) Revert part of r5290 and add font color corrections also. See #3596.

ptahdunbar2 years ago

Add the My Account label back

comment:10 johnjamesjacoby2 years ago

(In [5346]) Tweaks to WP toolbar menus:

  • WP3.3 compat
  • Move Notification bubble to right, next to my-account
  • Make my-account-buddypress a menu-group, so dependent children always follow
  • See #3596

comment:11 boonebgorges2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Marking this resolved, as we have released our 3.3-compatibility release. New issues can get new tickets.

Note: See TracTickets for help on using tickets.