Skip to:
Content

Opened 3 years ago

Closed 12 months ago

Last modified 12 months ago

#3588 closed enhancement (wontfix)

custom header image repeats on y-axis

Reported by: DJPaul Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.5
Component: Theme Keywords:
Cc:

Description

From http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/buddypress-1-5-rc1-default-template-header-graphic/

Uploading a custom header with the size of 1250x125px (as recommend on Appearance > Header) repeats on the y-axis. Actual height of header appears to be 133px.

Attachments (1)

3588.01.patch (519 bytes) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 boonebgorges3 years ago

Seems better to change the recommendation to match the CSS, right?

comment:2 DJPaul3 years ago

Yep. Height of header seems very arbitrary when you take into account browser zooms, etc. Could set background-repeat to no-repeat for the y-axis, but that looks a bit strange because it doesn't appear the image reaches the bottom of the main nav block… plus someone may be using that creatively.

comment:3 djpaul3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5155]) Set HEADER_IMAGE_HEIGHT to 133px. Fixes #3588

r-a-y3 years ago

comment:4 r-a-y3 years ago

  • Keywords has-patch added
  • Version set to 1.5

This is to do with the margins on #header #nav and #header #search-bar.

Tested this in v1.2.x and this issue is specific to 1.5 only, so I'd rather revert [5155] and remove the extra 7px of margins. See 01.patch.

Last edited 3 years ago by r-a-y (previous) (diff)

comment:5 r-a-y3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:6 DJPaul3 years ago

  • Milestone changed from 1.5 to 1.5.1
  • Type changed from defect to enhancement

Not for 1.5; no time to judge what the impact would be on any other templates within BP-Default. We can review this for a future release.

comment:7 r-a-y3 years ago

I'd make an argument that we should consider this issue for v1.5.0 because v1.5.0 hasn't been released yet.

If we release v1.5 as-is, you'd be telling users that 1250x133 is acceptable (133 is an odd number). Also, previous child themes that inherit v1.5 CSS will get this extra margin.

There shouldn't be any impact as far as templates are concerned.

comment:8 bobbingwide2 years ago

Having just developed my own solution before performing a search (to find this trac) my vote is for:

div#header { background-repeat: no-repeat; }

without this the repeated header image looked really horrible on narrow displays.

comment:9 DJPaul2 years ago

  • Milestone changed from 1.5.2 to 1.6

comment:10 johnjamesjacoby2 years ago

  • Milestone changed from 1.6 to Future Release

I think it's too late to tinker with this. Themes might already be working around it, and anything we do is going to noop something for someone. Punting to Future Release unless there's a compelling argument + a patch.

comment:11 DJPaul12 months ago

  • Keywords has-patch removed
  • Resolution set to wontfix
  • Status changed from reopened to closed

wontfixin' my own ticket because this could cause backwards compatibility issues with people using BP-Default.

comment:12 DJPaul12 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.