Changes between Initial Version and Version 1 of Ticket #3580, comment 3
- Timestamp:
- 09/15/2011 09:12:30 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #3580, comment 3
initial v1 1 Agree. I also noticed that, on non-multisite, the nag doesn't display for the activation/registration "components" when they haven't been mapped to a page. This is because multisite and regular WordPress use different option keys for enabling/disabling user registration. I'd like to change $bp->site_options['registration'] to $bp->site_options['users_can_register'] as multisite has a option_ filter… but I'm not 100% confident that swapping that wouldn't break something else at this point, so the patch has a safe fix .1 Agree. I also noticed that, on non-multisite, the nag doesn't display for the activation/registration "components" when they haven't been mapped to a page. This is because multisite and regular WordPress use different option keys for enabling/disabling user registration. I'd like to change $bp->site_options['registration'] to $bp->site_options['users_can_register'] as multisite has a option_ filter… but I'm not 100% confident that swapping that wouldn't break something else at this point, so the patch has a safe fix, but I'd love a second opinion.