Skip to:

Opened 7 years ago

Closed 7 years ago

Last modified 2 years ago

#3580 closed enhancement (fixed)

BuddyPress 1.5 Upgrade "Repair" message has conflicting (or potentially confusing) terms

Reported by: masonjames Owned by:
Milestone: 1.5 Priority: trivial
Severity: trivial Version: 1.5
Component: Core Keywords:


I'm attaching a screenshot to show this, but in the Repair notice you are told that you need pages to support the "Activate" and "Register" components.

Then below the components are referred to as "Sign-up" and "Activation". Why not make them the same and avoid potential confusion.

Attachments (2)

buddypress repair.pdf (82.5 KB) - added by masonjames 7 years ago.
3680-1.patch (1.2 KB) - added by DJPaul 7 years ago.

Download all attachments as: .zip

Change History (8)

7 years ago


#1 @masonjames
7 years ago

  • Version set to 1.5

#2 @boonebgorges
7 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Priority changed from normal to trivial
  • Severity changed from normal to trivial

I think that probably the lower text should be changed to match the upper. Any objections?

#3 @DJPaul
7 years ago

Agree. I also noticed that, on non-multisite, the nag doesn't display for the activation/registration "components" when they haven't been mapped to a page. This is because multisite and regular WordPress use different option keys for enabling/disabling user registration. I'd like to change $bp->site_optionsregistration? to $bp->site_optionsusers_can_register? as multisite has a option_ filter… but I'm not 100% confident that swapping that wouldn't break something else at this point, so the patch has a safe fix, but I'd love a second opinion.

Last edited 7 years ago by DJPaul (previous) (diff)

7 years ago

#4 @boonebgorges
7 years ago

+1 on the patch for the moment - only cosmetic changes at this point, unless they're critical.

#5 @djpaul
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5151]) Standardise missing page/component link nag warnings.
Also fix nag not appearing for the activation/registration pages.
Fixes #3580

#6 @DJPaul
2 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.