Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 8 years ago

Last modified 8 years ago

#3559 closed defect (bug) (worksforme)

groups/members/ dropdown filter broken?

Reported by: jonnyauk's profile Jonnyauk Owned by: r-a-y's profile r-a-y
Milestone: Priority: normal
Severity: normal Version: 1.2
Component: Groups Keywords: needs-patch
Cc:

Description

I think there may be a problem with the dropdown menu that filters the display order of members in groups - I have tried it on a couple of local installs, and also checked it out http://testbp.org/

When you try to use the filter to order group members (alphabetical, last active, newest registered), ajax-loader.gif kicks in on the navigation, but no re-ordering of the actual list of members happens.

BP1.5-beta-3

Change History (11)

#1 @Jonnyauk
13 years ago

As an aside - I should mention that the dropdown menu filter on the members directory does work.

#2 @boonebgorges
13 years ago

Would someone mind checking to see whether this works in 1.2.9? If it's being caused by what I suspect, it has never worked. I'm not near a computer at the moment so I can't check for myself.

#3 @Jonnyauk
13 years ago

I've been working on BP1.5 for so long that I'd forgotten what it was like! Just done a demo install to check out the issue mentioned - in BP1.2.9 there is no dropdown menu filter on groups/members - this seems to have been introduced in BP1.5.

#4 @boonebgorges
13 years ago

  • Milestone changed from Awaiting Review to 1.6

Thanks for looking.

As I suspected, the sorting was added in 1.5 (r3819). The same problem arose with respect to ajax pagination on group members pages; see #3406. In both cases, the "real" solution will be to rework how the ajax requests work. For BP 1.5, it's too late to be messing with this. I'm going to remove it from the templates for now, and punt this ticket to 1.6 for proper consideration after the 1.5 release.

#5 @boonebgorges
13 years ago

(In [5115]) Removes AJAX sorting from group member directories for the moment. See #3559

#6 @Jonnyauk
13 years ago

Yup - times too short, we all want 1.5 out in the wild! JS is my weakest area of dev, otherwise I'd pitch-in to fix it - agreed, something to revisit for 1.6;)

#7 @DJPaul
13 years ago

Punting to future release, probably 1.7, when we're gonna review all the javascript as part of the theme changes.

#8 @DJPaul
13 years ago

  • Milestone changed from 1.6 to Future Release

#9 @r-a-y
12 years ago

  • Keywords needs-patch added; needs-testing removed
  • Milestone changed from Future Release to 1.8
  • Owner set to r-a-y
  • Status changed from new to assigned
  • Version set to 1.2

I've done some work recently to add the AJAX dropdown functionality into a custom members loop.

Currently, everything depends on the naming of the IDs and CSS classes in certain elements as the JS explicitly relies on this.

Will look to add this back in 1.8.

#10 @boonebgorges
12 years ago

  • Milestone changed from 1.8 to Future Release

#11 @slaFFik
8 years ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

Tested with the latest code, and it seems this task is no longer valid - sorting works by Newest, Oldest, Group activity and Alphabetical.

Last edited 8 years ago by slaFFik (previous) (diff)
Note: See TracTickets for help on using tickets.