Forum cookies are being too persistent

[boonebgorges]

Do the following:

• Go to ​http://testbp.org/forums
• Select something from the dropdown
• Go to ​http://testbp.org/members/johnjamesjacoby
• Select something from the dropdown
• Look at the pagination numbers
• Go back to ​http://testbp.org/forums.

Things are broken in several of these places. I think the problem is that cookies are getting set that are not getting flushed at the appropriate times.

[boonebgorges]

I'm beginning to think that there are problems here beyond cookies. At least in the case of Unreplied filters, the reason why the count is off is that we're not doing a query anywhere to get the total number of unreplied items (we're just relying on the total topic count for the user). The same thing happened recently with "replied to"; I wrote a function to query, which I guess I can do again for this case, though I am wary of putting a bunch of functions for these single purposes throughout.

[boonebgorges]

(In [5129]) Reworks the way that total topic counts are retrieved on user forum pages. See #3557

[boonebgorges]

I believe this has been fixed by r5129 (which had nothing to do with cookies, btw). Marking as such. Please reopen if you find specific problems.