Opened 13 years ago
Closed 13 years ago
#3539 closed defect (bug) (fixed)
Group forum stickies are ignored when queried with AJAX
Reported by: | boonebgorges | Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Forums | Keywords: | has-patch needs-testing 2nd-opinion |
Cc: |
Description
When selecting one of the topic filters from the dropdown (Most Posts, Last Active, etc), the topics returned do not include any stickies. This only appears to be the case on individual group forums.
Attachments (1)
Change History (6)
Note: See
TracTickets for help on using
tickets.
This ended up being a deeper problem than I thought. Essentially, it boils down to the fact that the bp-forums-scope cookie is being set incorrectly. It is set, through a somewhat convoluted process, according to the CSS classes of the group forum navigation tabs. More specifically, because the options_nav was being constructed so that the tabs had the class 'forums-personal-li', the scope cookie was being set as 'personal'. This seems like an oversight to me: those navigation tabs should have the class .forums-groups-li when looking at a group. See 3539.01.patch. (The patch also contains a minor fix that passes some missing parameters along the bp_has_forum_topics() path - it's not a vital part of the patch.)
I want to get a second opinion about this. I am pretty certain that I've correctly identified the problem, but I want some feedback regarding the wisdom of changing these classes. The concern with changing selectors is that it will break styling and/or javascript in some child themes. It didn't actually break or change anything in bp-default, so I think it's pretty unlikely that there will be many issues, but it's a possibility. Anyone else care to chime in on this?