Skip to:

Opened 13 years ago

Closed 13 years ago

#3539 closed defect (bug) (fixed)

Group forum stickies are ignored when queried with AJAX

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Forums Keywords: has-patch needs-testing 2nd-opinion


When selecting one of the topic filters from the dropdown (Most Posts, Last Active, etc), the topics returned do not include any stickies. This only appears to be the case on individual group forums.

Attachments (1)

3539.01.patch (4.9 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (6)

#1 @boonebgorges
13 years ago

  • Keywords has-patch needs-testing 2nd-opinion added

This ended up being a deeper problem than I thought. Essentially, it boils down to the fact that the bp-forums-scope cookie is being set incorrectly. It is set, through a somewhat convoluted process, according to the CSS classes of the group forum navigation tabs. More specifically, because the options_nav was being constructed so that the tabs had the class 'forums-personal-li', the scope cookie was being set as 'personal'. This seems like an oversight to me: those navigation tabs should have the class .forums-groups-li when looking at a group. See 3539.01.patch. (The patch also contains a minor fix that passes some missing parameters along the bp_has_forum_topics() path - it's not a vital part of the patch.)

I want to get a second opinion about this. I am pretty certain that I've correctly identified the problem, but I want some feedback regarding the wisdom of changing these classes. The concern with changing selectors is that it will break styling and/or javascript in some child themes. It didn't actually break or change anything in bp-default, so I think it's pretty unlikely that there will be many issues, but it's a possibility. Anyone else care to chime in on this?

#2 @johnjamesjacoby
13 years ago

Maybe related, the ajax query pagination goes a little weird when switching tabs, changing the drop-down, and viewing within your profile. Able to reproduce on

#3 @boonebgorges
13 years ago

(In [5111]) Changes CSS class on group tabs so that AJAX is run correctly. References #3539.

#4 @boonebgorges
13 years ago

jjj - Can you be more specific about how to reproduce?

#5 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

jjj has given me more details. It's unrelated. Marking this ticket as closed.

Note: See TracTickets for help on using tickets.