Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 6 years ago

#3519 closed enhancement (wontfix)

Messaging buttons (no spinners)

Reported by: xeqta Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Messages Keywords:
Cc:

Description

The 2 buttons inside the messaging component has no spinners. It sometimes takes a bit to send/delete a message, so it makes sense to add them to these buttons as well. ("Send Message", "Delete").

(testbp.org)

Change History (4)

#1 @johnjamesjacoby
9 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Version 1.5 deleted

Confirmed. Spinner JS probably needs a once over. Related #3448 #3506

#2 @boonebgorges
9 years ago

  • Milestone changed from 1.5 to Future Release
  • Type changed from defect to enhancement

At the moment, we only use spinners for actions that take place using AJAX. "Send Message" and "Delete" do not have AJAX methods associated with them; they work with a regular form submit. I don't think we should adopt the convention of attaching the loading class to buttons when they're not truly ajaxified - I have never seen this done anywhere else on the web.

For that reason, I'm switching this to an enhancement request, that should be covered at which time we do an AJAX implementation.

#3 @DJPaul
9 years ago

I agree with Boone. wontfix for current BP-Default?

#4 @boonebgorges
6 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Yes, wontfix, unless all this is rewritten to use AJAX.

Note: See TracTickets for help on using tickets.