Opened 13 years ago
Closed 13 years ago
#3515 closed enhancement (fixed)
add $username to bp_core_get_user_domain filter
Reported by: | sboisvert | Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | minor |
Severity: | minor | Version: | 1.5 |
Component: | Members | Keywords: | |
Cc: | sboisvert |
Description
Good day,
I would like to suggest 2 separate patches for your consideration. The first simply adds $username to the bp_core_get_user_domain filter, while the other adds a filter that also has the extra username parameter just before the cache is set called bp_core_get_user_domain_pre_cache (There may be a preferred nomenclature that I am not familiar with regarding naming pre cache filters).
$username was picked over $user_id,$user_nicename or $user_login because it is guaranteed to be available while the others may not depending on how the function was called.
Attachments (2)
Change History (4)
#1
@
13 years ago
- Milestone changed from Awaiting Review to 1.5
- Priority changed from normal to minor
We can pass along all the parameters to the filter; if the supplemental ones are not provided, they default to false. It's probably best to send the $user_id first, since that's the primary index for users (and will also always be available).
Also, for future patches - would you mind running the diff from the root of the buddypress installation? It makes for one less step for me when patching :)
with filter before cache set