Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

#3487 closed defect (bug) (no action required)

BuddyPress installer/updater component slugs

Reported by: sushkov Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-patch
Cc: stas@…

Description

Right now the installer is not aware of custom defined component slugs.

source:/trunk/bp-core/admin/bp-core-update.php#391 ignores possible manual definitions of components slug (ex. BP_GROUPS_SLUG, like in case of <component>::setup_globals())

Change History (4)

#1 @boonebgorges
8 years ago

On a new installation, BP core files have not been loaded at this point. The data in ::setup_globals() is therefore not available.

During inter-1.5 upgrades, core files *are* loaded. But in that case, we should be looking at root_slug rather than slug. (So that's a bug, and should be patched. Though it doesn't matter that much, because the Pages step won't generally be loaded on upgrades after 1.5.)

Because we are looking at root_slugs rather than regular slugs, we should *not* be respecting BP_{component}_SLUG overrides in wp-config.php, since these constants no longer affect the root slugs in BP 1.5.

#2 @sushkov
8 years ago

Aha, thanks a lot, this make it clear now.

#3 @johnjamesjacoby
8 years ago

  • Keywords needs-patch added; dev-feedback removed
  • Milestone changed from Awaiting Review to 1.5
  • Version 1.5 deleted

#4 @boonebgorges
8 years ago

  • Resolution set to invalid
  • Status changed from new to closed

I think there's nothing to resolve here. Marking closed.

Note: See TracTickets for help on using tickets.