Opened 14 years ago
Closed 13 years ago
#3450 closed defect (bug) (worksforme)
avatar image not showing correctly on registration / signup
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | |
Cc: |
Description
relates to BP 1.2.9 running on wp 3.2.1
see also
In theme bp-default register.php there should be a hidden field in the section below "Your Current Avatar" to pass along the bp signup avatar directory for the new user.
This hidden field is present when the user uploads the avatar but not before and after uploading (during registration). Hence the function bp_get_signup_avatar_dir_value() does not know the value of the registrant's avatar upload dir.
Alos, I think the function
bp_get_signup_avatar_dir_value() has a bug.
I can't figure out when $bp->signup->avatar_dir would actually have a value or why it should be passed to the filter at the bottom of the function.
function bp_get_signup_avatar_dir_value() {
global $bp;
Check if signup_avatar_dir is passed
if ( !empty( $_POSTsignup_avatar_dir? ) ) {
$signup_avatar_dir = $_POSTsignup_avatar_dir?;
}
If not, check if global is set
elseif ( !empty( $bp->signup->avatar_dir ) )
$signup_avatar_dir = $bp->signup->avatar_dir;
If not, set false
else
$signup_avatar_dir = false;
Seems to be a bug here. replaced $bp->signup->avatar_dir with $signup_avatar_dir
(original)
return apply_filters( 'bp_get_signup_avatar_dir_value', $bp->signup->avatar_dir );
(proposed fix)
return apply_filters( 'bp_get_signup_avatar_dir_value', $signup_avatar_dir );
}
Change History (3)
#2
@
14 years ago
As noted in the forum post, I'd like to backtrack on the hidden field suggestion. However, I still think bp_get_signup_avatar_dir_value() has a bug.
Also to clarify, during the registration the uploading and cropping works. It's the display of the avatar before and after uploading that is faulty.
Interesting that this might be removed in 1.5.
The upload avatar at registration has been removed in BP 1.5's theme. Uploading an avatar and cropping it after registration works fine for me.