Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #3447, comment 10


Ignore:
Timestamp:
08/08/2011 11:27:06 PM (13 years ago)
Author:
boonebgorges
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3447, comment 10

    initial v1  
    1 When you set the default with a value like $hide_empty_fields, and then use extract( $r, EXTR_SKIP );, $r['hide_empty_fields'] will not be extracted, but $hide_empty_fields will retain its previous value. If we leave out EXTR_SKIP, it's irrelevant - but in any case it seems like bad practice to use the same variable name, in the same function scope, for two different purposes.
     1When you set the default with a value like $hide_empty_fields, and then use extract( $r, EXTR_SKIP );, $r[[['hide_empty_fields']]] will not be extracted, but $hide_empty_fields will retain its previous value. If we leave out EXTR_SKIP, it's irrelevant - but in any case it seems like bad practice to use the same variable name, in the same function scope, for two different purposes.