Skip to:

Opened 13 years ago

Closed 13 years ago

#3445 closed defect (bug) (fixed)

Blog posts not showing in activity stream

Reported by: modemlooper's profile modemlooper Owned by:
Milestone: 1.5 Priority: critical
Severity: critical Version: 1.5
Component: Activity Keywords: dev-feedback has-patch needs-testing

Description (last modified by DJPaul)

Blog posts in non-multisite installs are not appearing in the activity stream.

This is because the Blogs component is not loaded. This is a regression from BP 1.2.9 where the Blogs component was being loaded (because it wasn't explicitly disabled) and posts were appearing in the activity stream.

Attachments (3)

3445-1.patch (9.8 KB) - added by DJPaul 13 years ago.
3445-2.patch (11.5 KB) - added by boonebgorges 13 years ago.
3445-3.patch (11.4 KB) - added by DJPaul 13 years ago.

Download all attachments as: .zip

Change History (11)

#1 @modemlooper
13 years ago

Just re-read that. Yikes, grammar!

#2 @DJPaul
13 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 1.5
  • Priority changed from normal to critical
  • Severity changed from normal to critical
  • Summary changed from Blog posts not showing in activity stream or the show filter to Blog posts not showing in activity stream

#3 @DJPaul
13 years ago

  • Keywords dev-feedback added

13 years ago

#4 @DJPaul
13 years ago

  • Keywords has-patch needs-testing added

Patch attached re-configures site tracking component to load for both ms and non-ms. It restores activity stream posting.
Patch also removes unused bp_core_admin_dashboard() from early 1.3 development. Please help by eyeballing the changes, and testing.

1) step_pages() -- had duplicated descriptions for Site, Forum and Group component. I've done a real edit on those descriptions, and they might need tweaking.

2) Can we remove step_ms_update() now?

#5 @DJPaul
13 years ago

Boone & I discussed this a little on IRC. We'll need to tweak this patch so that:

1) Force $bp->blogs->has_directory to false when !is_multisite()
2) Modify set up wizard so that it only prompts to create pages for has_directory components

#6 @boonebgorges
13 years ago

Thanks for the patch, DJPaul. Looks mostly good. I have made a few tweaks:

1) Changed some wording, especially to account for the fact that non-MS installations will not have a Sites directory.
2) Set $bp->blogs->has_directory to is_multisite()
3) Fixed the places where the original patch wouldn't apply cleanly because of recent whitespace cleanup :)

step_ms_update(): I think we need to keep step_ms_update(). Someone who has disabled the Blogs component on non-MS may very well want it enabled on MS. Moreover, even if we assume that activation status will remain, we need to prompt to create a Sites directory page (since one does not exist on non-MS).

->has_directory during update: It's not possible to check this consistently, because during initial installation of BP, the rest of the BP files have not been loaded, with the result that the components have not registered themselves, and ->has_directory is not populated one way or the other. As an alternative, I have simply opted not to show the Sites option during step_pages() when !is_multisite(), with the result that no page is created. I think this is the best we can do at the moment.

See 3445-2.patch

13 years ago

#7 @DJPaul
13 years ago

I found/fixed an i18n text domain error. I also changed the description of the site tracking component depending if you're looking at it on multisite or non-multisite. Talking about "…across your entire network" on a non-multisite doesn't make sense.

#8 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4965]) Fix blog posts not showing in activity stream in non-multisites. Fixes #3445, props boonebgorges and paulgibbs

Note: See TracTickets for help on using tickets.