Error / success messages do not get shown for group extensions

[travel-junkie]

Because of the priority order of the bp_actions hook, no error or success messages are output for group extensions.

Group extensions are registered at bp_actions with a priority of 8, but template notices get shown with the default priority of 10.

Registering group extensions at priority 10 seems to solve the issue.

[DJPaul]

I haven't looked at this yet, but keep in mind r4051

[boonebgorges]

Right. Those priorities are a delicate balance. I would rather make template notices show earlier. I'll look later if no one gets to it.

[boonebgorges]

I've just run a quick test.

1) I can only verify travel-junkie's report for group extension tabs on the Group Admin. Eg, for BuddyPress Docs, notices are *not* working on Group Admin > Docs, when you save settings. Notices are working fine in the main group extension tab itself.

2) I've just reconfirmed that the group extension will not be detected during the group creation process if it's hooked with priority 10.

Going to continue to investigate a solution. travel-junkie, can you verify that my (1) is correct?

[boonebgorges]

My suggested solution is 3427.01.patch. It moves up the priority of bp_core_setup_message(). This seems the safest solution, and in fact is probably desirable, as we will almost always want bp_core_setup_message() to be among the first things fired.

[DJPaul]

I've just given this a test, and it seems to work fine.

[djpaul]

(In [4919]) Ensure that error/success from group extensions always show. Fixes #3427

[DJPaul]

Sorry, Boone -- forgot your props. All hail Boone!

[travel-junkie]

Bit late, but 1 is correct, Boone.