Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3427 closed defect (bug) (fixed)

Error / success messages do not get shown for group extensions

Reported by: travel-junkie Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version: 1.5
Component: Groups Keywords: has-patch
Cc:

Description

Because of the priority order of the bp_actions hook, no error or success messages are output for group extensions.

Group extensions are registered at bp_actions with a priority of 8, but template notices get shown with the default priority of 10.

Registering group extensions at priority 10 seems to solve the issue.

Attachments (1)

3427.01.patch (606 bytes) - added by boonebgorges 8 years ago.

Download all attachments as: .zip

Change History (10)

#1 @DJPaul
8 years ago

I haven't looked at this yet, but keep in mind r4051

#2 @boonebgorges
8 years ago

Right. Those priorities are a delicate balance. I would rather make template notices show earlier. I'll look later if no one gets to it.

#3 @boonebgorges
8 years ago

I've just run a quick test.

1) I can only verify travel-junkie's report for group extension tabs on the Group Admin. Eg, for BuddyPress Docs, notices are *not* working on Group Admin > Docs, when you save settings. Notices are working fine in the main group extension tab itself.

2) I've just reconfirmed that the group extension will not be detected during the group creation process if it's hooked with priority 10.

Going to continue to investigate a solution. travel-junkie, can you verify that my (1) is correct?

Last edited 8 years ago by boonebgorges (previous) (diff)

#4 @boonebgorges
8 years ago

  • Keywords has-patch added

My suggested solution is 3427.01.patch. It moves up the priority of bp_core_setup_message(). This seems the safest solution, and in fact is probably desirable, as we will almost always want bp_core_setup_message() to be among the first things fired.

#5 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.5

#6 @DJPaul
8 years ago

I've just given this a test, and it seems to work fine.

#7 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4919]) Ensure that error/success from group extensions always show. Fixes #3427

#8 @DJPaul
8 years ago

Sorry, Boone -- forgot your props. All hail Boone!

#9 @travel-junkie
8 years ago

Bit late, but 1 is correct, Boone.

Note: See TracTickets for help on using tickets.