Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3348 closed defect (bug) (fixed)

Buttons placement in permalink page

Reported by: xeqta's profile xeqta Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

Please see attachment. Tested in firefox on testbp.org.

Attachments (7)

permalink.jpg​ (76.9 KB) - added by xeqta 13 years ago.
no-content.png​ (56.8 KB) - added by luccame 13 years ago.
short-content.png​ (62.4 KB) - added by luccame 13 years ago.
long-content.png​ (62.9 KB) - added by luccame 13 years ago.
3348.01.patch​ (1.2 KB) - added by r-a-y 13 years ago.
3348.02.patch​ (1.4 KB) - added by r-a-y 13 years ago.
3348.03.patch​ (1.8 KB) - added by r-a-y 13 years ago.
Updated patch for activity permalink mini items

Download all attachments as: .zip

Change History (16)

@xeqta
13 years ago

#1 @DJPaul
13 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Can't recreate on trunk or testbp.org. Tested on Firefox 3.6.6 and Firefox 5.0.1, both on OS X.

#2 @luccame
13 years ago

  • Resolution worksforme deleted
  • Severity set to normal
  • Status changed from closed to reopened

I can see this one on Ubuntu with Chromium 12.0.742.112 (90304) and Firefox 5

@luccame
13 years ago

@luccame
13 years ago

@luccame
13 years ago

@r-a-y
13 years ago

@r-a-y
13 years ago

#3 @r-a-y
13 years ago

  • Keywords has-patch added

Confirmed.

Attached patch is tested on FF 3.6.18, Chrome 11, Opera 11.5 and IE8.

FYI, BP makes use of the last-child CSS selector to remove the margin-bottom on the last paragraph; in IE8 and lower, last-child isn't supported so that's why there's additional margin-bottom.

#4 @DJPaul
13 years ago

  • Keywords dev-feedback added

Boone or John, can you recreate this? I'm not putting it as I couldn't.

@r-a-y
13 years ago

Updated patch for activity permalink mini items

#5 @r-a-y
13 years ago

  • Component changed from Core to Theme

You don't trust me? ;)

Try logging in and navigating to an activity permalink page.
I was able to duplicate luccame's screenshots on mostly every browser.

#6 @johnjamesjacoby
13 years ago

I think I accidentally fixed this in r4747. Confirm?

#7 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version 1.3 deleted

#8 @r-a-y
13 years ago

Yes r4747 fixes the issue.

However, my patch also addressed a few spacing inconsistencies between activity entries and the activity form.

I'll open a new ticket for this.

#9 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.