Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#3325 closed defect (bug) (fixed)

Global and root slug audits

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Core Keywords: close
Cc:

Description

Came across a few incorrect references to normal slugs when they should be using the new root slugs. Also we're still using the globals in quite a few places which means those spots won't get handled by the filters in all places.

Attached patch is for the Activity component, and touches Groups in a few places too.

Attachments (1)

activity.patch (13.9 KB) - added by johnjamesjacoby 13 years ago.
Activity Slug Audit

Download all attachments as: .zip

Change History (23)

@johnjamesjacoby
13 years ago

Activity Slug Audit

#1 @johnjamesjacoby
13 years ago

  • Keywords has-patch needs-patch added

#2 @johnjamesjacoby
13 years ago

(In [4646]) Audit the usage of $bp->activity->slug. See #3325.

#3 @johnjamesjacoby
13 years ago

(In [4647]) Audit the usage of $bp->friends->slug. See #3325.

#4 @johnjamesjacoby
13 years ago

(In [4648]) Audit the usage of $bp->groups->slug. See #3325.

#5 @johnjamesjacoby
13 years ago

(In [4649]) Audit the usage of $bp->groups->root_slug. See #3325.

#6 @johnjamesjacoby
13 years ago

(In [4650]) Audit the usage of $bp->members->slug and $bp->members->root_slug. See #3325.

#7 @johnjamesjacoby
13 years ago

(In [4651]) Audit the usage of $bp->blogs->slug and $bp->blogs->root_slug. See #3325.

#8 @johnjamesjacoby
13 years ago

(In [4652]) Audit the usage of $bp->forums->slug and $bp->forums->root_slug. See #3325.

#9 @boonebgorges
13 years ago

(In [4677]) Ensure that activity permalinks work by doing the correct bp_is_activity_component() check. See #3325

#10 @boonebgorges
13 years ago

  • Keywords close added; has-patch needs-patch removed
  • Severity set to normal

What's the status here? Can we close the ticket?

#11 @johnjamesjacoby
13 years ago

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

#12 follow-up: @boonebgorges
13 years ago

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

Ugh. That will not be a simple find-and-replace, unless you are way awesomer at regex than I am.

#13 in reply to: ↑ 12 @johnjamesjacoby
13 years ago

Replying to boonebgorges:

This still needs a function for $bp->action_variables to check for and return an array item. We define the $bp global and do a bunch of isset( $bp->action_variables[1] ) type checks everywhere. Once that gets a function and find/replace, it's good.

Ugh. That will not be a simple find-and-replace, unless you are way awesomer at regex than I am.

I'm not, buit my IDE is.

Version 0, edited 13 years ago by johnjamesjacoby (next)

#14 follow-up: @boonebgorges
13 years ago

Does that mean you're doing it?

#15 in reply to: ↑ 14 @johnjamesjacoby
13 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to accepted

Replying to boonebgorges:

Does that mean you're doing it?

Yes. :)

#16 @djpaul
13 years ago

(In [4809]) Remove remaining · from templates.
Normalise output of bp_get_member_latest_update() and bp_get_activity_latest_update().
Swapped remaing $bp->activity->root_slug for bp_get_activity_root_slug(). See #3325

#17 @boonebgorges
13 years ago

(In [4840]) Introduces wrapper functions for retrieving and checking items in bp->action_variables. action_variables audit for xprofile component. See #3325

#18 @boonebgorges
13 years ago

(In [4842]) Global/slug review in Settings and Messages component. See #3325

#19 @boonebgorges
13 years ago

(In [4844]) Global/slug audit for groups component. Also regularizes the way that some group forum actions are concatenated. See #3325

#20 @boonebgorges
13 years ago

(In [4845]) Global/slug audit in Friends component. See #3325

#21 @boonebgorges
13 years ago

(In [4846]) Global/slug audit in forums component. See #3325

#22 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [4847]) Global/slug audit in Core and Activity components. Fixes #3325

Note: See TracTickets for help on using tickets.