Skip to:

Opened 13 years ago

Closed 13 years ago

#3307 closed defect (bug) (fixed)

Site/Root-blog option migration runs on every pageload

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:


Was auditing queries for 1.3 and noticed some of what was introduced in r4559 isn't working as intended. Because the same variables are never added to the root blog, the two checks never line up and the whole routine runs on every pageload.

Attached patch seems to fix this, but deserves some testing since it effects single/multi site and 1.2/1.3 settings. It's worth mentioning that a complete audit of the settings pages is pending, which may or may-not render this a moot point.

Attachments (1)

3307.patch (7.3 KB) - added by johnjamesjacoby 13 years ago.

Download all attachments as: .zip

Change History (2)

#1 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4587]) Rename bp_core_get_site_options() to bp_core_get_root_options() and fix issue where moved site settings would not completely migrate, causing migration to run on each page load. Fixes #3307. See #3313 and r4585.

Note: See TracTickets for help on using tickets.