Skip to:
Content

Opened 4 years ago

Closed 14 months ago

Last modified 14 months ago

#3288 closed enhancement (invalid)

Load core js/css in the same way as WP script-loader.php does

Reported by: DJPaul Owned by:
Milestone: Priority: minor
Severity: normal Version:
Component: Component - Core Keywords:
Cc:

Description

If we load core JS/CSS in the same way as WP core script-loader.php does, we can avoid having to IF and checking for SCRIPT_DEBUG everywhere.

Change History (2)

comment:1 @boonebgorges14 months ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Severity set to normal
  • Status changed from new to closed

I'm not 100% sure what this ticket is suggesting. Is the idea that we should register all our scripts in a central location, and only register them later? Or is it that we should be using the 'wp_default_scripts' hook? I guess I don't see much of an advantage to centralizing things. Instead of doing SCRIPT_DEBUG checks, we'd end up doing bp_is_active() checks. Or we could do some sort of fancy subhook system, but it seems like there's not much to be gained in terms of efficiency with our fairly limited number of assets.

Going to close this one. DJPaul, if I've misunderstood, or you strongly disagree, please feel free to reopen and set me straight ;)

comment:2 @DJPaul14 months ago

I can't really remember what I had for breakfast a week ago, let alone what I meant by a vague not-so-well-written ticket three years ago, so closing is fine. :)

Note: See TracTickets for help on using tickets.