Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3272 closed defect (bug) (fixed)

Delete function does not work on IE

Reported by: ezd's profile Ezd Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Activity Keywords:


I only tested this on IE.

When I make an update and I delete it again it looks like it's deleted but when I refresh the page it's back.


Change History (10)

#1 @DJPaul
13 years ago

Works for me. Tested in a few browsers on Mac, and IE9 on Windows.

#2 @DJPaul
13 years ago

  • Keywords reporter-feedback added

#3 @Dennissmolek
13 years ago

Confirmed on via IE8 and FF 4.0.1.

When Adding an update then deleting it via the same page via ajax it removes it from the list but leaves it by the avatar with the view button. Clicking it still pulls that activity.

Also, when reloading the page the activity shows back up, when clicking delete an alert asks "are you sure?" Then removes it from the list.

Refreshing the page, and the activity is still being listed.
Adding a new update does not affect it. I cannot delete activities from my profile, they disappear with the ajax but come right back.

Testing this on my test server does not do this. My server is a few days off trunk, I'll update it and see what happens..

#4 @Dennissmolek
13 years ago

Test site is at trunk and works fine. Test BP is where the issue is. Im going to check a user with a lower role.

#5 @Dennissmolek
13 years ago

Yep thats the issue.

Tested on trunk, lower role users cannot delete activities. Once set to admin you can, but otherwise the ajax removes it from the list, seems to hang, and then when you refresh it appears again..

#6 @DJPaul
13 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 1.3
  • Owner set to DJPaul
  • Status changed from new to assigned

This broke in r4469

#7 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4548]) Fix deleting activity stream items. Fixes #3272

#8 @boonebgorges
13 years ago

Was there no way to fix this that maintained bp_activity_user_can_delete() in the ajax? Now plugins can't manipulate the ajax. Not a huge deal, but that is the purpose of the wrapper.

#9 @DJPaul
13 years ago

It is still in there; I just added an optional argument to the function because it was originally used inside the activity loop.

#10 @boonebgorges
13 years ago

My bad, I misread the patch.

Note: See TracTickets for help on using tickets.