Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3259 closed enhancement (fixed)

Check CSS for WP CSS Standards compliance

Reported by: hnla Owned by:
Milestone: 1.5 Priority: minor
Severity: Version:
Component: Templates Keywords:
Cc: hnla

Description (last modified by DJPaul)

Check all CSS in BuddyPress so that it better follows the WordPress CSS standards, as detailed on http://codex.wordpress.org/CSS_Coding_Standards.

Attachments (3)

3259-add-border-radius-default-styles.patch (14.0 KB) - added by hnla 8 years ago.
Add border-radius and tidy up ordering of properties
3259-further-clean-up-css-to-sec2.8 (10.9 KB) - added by hnla 8 years ago.
3259-completed-properties-reordering.patch (20.5 KB) - added by hnla 8 years ago.
Completes the re-ordering of properties in complience with WP guidelines

Download all attachments as: .zip

Change History (18)

@hnla
8 years ago

Add border-radius and tidy up ordering of properties

#1 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3

There's quite a bit of stuff in the CSS that doesn't match up to the WordPress CSS Guidelines exactly, but every patch helps :)

#2 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4446]) Add missing border-radius (etc) selectors to vendor-specific versions.
Also tidies up some of the blocks. Fixes #3259, props hnla

#3 @hnla
8 years ago

Yeah hadn't realised quite so much didn't follow coding guidelines, thought a lot had been cleaned up. Would have attempted more but it was starting to eat into time, and it's one of those kind of tasks that are a chore with little gratification at the end of it :) This gets the sheet ~2/3 of the way there though, as it's committed I'll update and do a little more if I get a moment.

hah see I managed to miss a few alfi beticals

Last edited 8 years ago by hnla (previous) (diff)

#4 @hnla
8 years ago

A few more clean ups alfi betically - up to section 2.8 of sheet

#5 @hnla
8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hmm I should have changed the resolution back to open after adding this further patch?

#6 @DJPaul
8 years ago

This doesn't apply to the current trunk (probably because the CSS keeps being reorganised). Can you repatch please?

#7 @DJPaul
8 years ago

  • Priority changed from normal to trivial

#8 @hnla
8 years ago

First patch was commited? this contained the border-radius additions and some property re-ordering.

Second patch was an attempt to chip away at a little more re-ordering of properties and if it can't be committed so be it :(

However I thought that when I updated to check out the stylesheet structuring that karmatosed submitted that she had actually included a final re-order of properties?

#9 @DJPaul
8 years ago

If the second patch was just a further effort at tidying up the CSS to better follow WordPress CSS guidelines, I'll switch this ticket to an enhancement for a future release to clear the 1.3 milestone. Thanks for the earlier patch (which has been committed) :)

#10 @DJPaul
8 years ago

  • Description modified (diff)
  • Keywords theme default.css removed
  • Milestone changed from 1.3 to Future Release
  • Priority changed from trivial to minor
  • Summary changed from Corect missing border-radius, apply wp coding standards to rulesets to Check CSS for WP CSS Standards compliance
  • Type changed from defect to enhancement

#11 @hnla
8 years ago

I was wrong, it isn't done so it's a real shame that second patch didn't squeeze in as it had done the majority, I'll do a little as and when I can but need to avoid that happening again as it's wasted time.

Question: surely you can merge files not just branches with SVN?

@hnla
8 years ago

Completes the re-ordering of properties in complience with WP guidelines

#12 @hnla
8 years ago

PAUL quick commit it now - fast, before default gets changed again! :)

#13 @DJPaul
8 years ago

  • Milestone changed from Future Release to 1.3

#14 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [4477]) Reorder bp-default css so it better follows WordPress CSS standards. Fixes #3259, big props hnla

#15 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.