#3249 closed defect (bug) (fixed)
comment list callback comment reply reply link empty div if comments off
Reported by: | hnla | Owned by: | |
---|---|---|---|
Milestone: | 1.5 | Priority: | normal |
Severity: | Version: | 1.5 | |
Component: | Templates | Keywords: | comment reply link, comment options |
Cc: | hnla |
Description
As the label says. A comment placed has div.comment-options with a comment_reply_link() for nested replies all good, however if comments are 'off' this reply link function returns zilch leaving empty div,
This patch adds a conditional check for comments_open() and if not does else: _e('Replies to comments are closed.
The patch also corrects an issue where a stray &maddot is left in the nested comments comment-meta removing the · if comments closed
Attachments (1)
Change History (7)
#2
@
13 years ago
Thanks for the patch. About to put it in, but I've left out the "Replies to comments are closed" bit as that was redundantly appearing on every comment. Twentyten and Twentyeleven just doesn't display a message in this situation. We might, but not inside the list of comments. I think we're going to handle that in #3245, anyway.
#3
@
13 years ago
I'm also aware this messes up bottom margin when comments are disabled, but an empty element obviously isn't the solution (plus, the spacing's all off, anyway). To be resolved as part of #3242.
#5
@
13 years ago
Yep point taken about the message on each comment reply being redundant, wasn't sure and was dithering over whether it seemed right. yes there was still the issue of comments.php and it's conditional logic for comment notifications to be dealt with I've a two thirds re-working on test install.
Add 'Replies to comments closed' for comments to posts when general comments 'Off'