Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3249 closed defect (bug) (fixed)

comment list callback comment reply reply link empty div if comments off

Reported by: hnla's profile hnla Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords: comment reply link, comment options
Cc: hnla


As the label says. A comment placed has div.comment-options with a comment_reply_link() for nested replies all good, however if comments are 'off' this reply link function returns zilch leaving empty div,

This patch adds a conditional check for comments_open() and if not does else: _e('Replies to comments are closed.

The patch also corrects an issue where a stray &maddot is left in the nested comments comment-meta removing the &middot if comments closed

Attachments (1)

#3249-add-replies-to-comments-closed-for-comments.patch (2.1 KB) - added by hnla 13 years ago.
Add 'Replies to comments closed' for comments to posts when general comments 'Off'

Download all attachments as: .zip

Change History (7)

13 years ago

Add 'Replies to comments closed' for comments to posts when general comments 'Off'

#1 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to 1.3

#2 @DJPaul
13 years ago

Thanks for the patch. About to put it in, but I've left out the "Replies to comments are closed" bit as that was redundantly appearing on every comment. Twentyten and Twentyeleven just doesn't display a message in this situation. We might, but not inside the list of comments. I think we're going to handle that in #3245, anyway.

#3 @DJPaul
13 years ago

I'm also aware this messes up bottom margin when comments are disabled, but an empty element obviously isn't the solution (plus, the spacing's all off, anyway). To be resolved as part of #3242.

#4 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4419]) Don't show a middle-dot and empty div when comments disabled. Fixes #3249, props hnla

#5 @hnla
13 years ago

Yep point taken about the message on each comment reply being redundant, wasn't sure and was dithering over whether it seemed right. yes there was still the issue of comments.php and it's conditional logic for comment notifications to be dealt with I've a two thirds re-working on test install.

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.