Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3216 closed defect (bug) (fixed)

register_sidebar 'sidebar' borked

Reported by: hnla Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords:
Cc: hugoashmore@…

Description

Sidebar widget area is broken.

In 1.2.8 array registered as 'name'=> 'sidebar' no ID

In 1.3 array registered with id => 'sidebar-1'

sidebar.php calls 'dynamic_sidebar( 'sidebar' )

didn't bother with a patch as it's a simple fix.

Change History (6)

#1 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3

#2 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4359]) Correct name of sidebar loaded in sidebar.php. Fixes #3216, props hnla

#3 @hnla
8 years ago

Am I being dense? I fixed it the opposite way round and changed functions.php register_sidebar id => 'sidebar' instead of 'sidebar-1'. Loading ('sidebar-1') in sidebar.php simply refused to work for me.

#5 @hnla
8 years ago

Hmm read that, took a minute to get my head around the issue, then thought I had understood the problem and changed all back to 'sidebar-1' and set a new widget in sidebar, but I still can not get it to display.

I've perhaps not seen this issue or understood it as always thought one had to set the ID and always have done.

As long as the issue just rest with me and you're happy all is ok I'll revisit later and figure out the issue.

#6 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.