Persistent login error on wp-login.php

[r-a-y]

A persistent login error message appears on wp-login.php even when you haven't submitted the form.

Steps to reproduce:

1) Using WP 3.1.2, activate BP 1.3-bleeding.

2) Make sure you're not logged in. Navigate to /wp-login.php. You'll see the following error message:

ERROR: Invalid username or incorrect password.

3) Deactivate BP 1.3-bleeding. Log out. Navigate to /wp-login.php. Error message disappears.

Example:
​http://testbp.org/wp-login.php (make sure you're not logged in)

---

I've traced this error message to the pluggable WP function ​wp_authenticate() but I'm not sure whereabouts in BP is causing this problem.

[DJPaul]

I'm not sure how BuddyPress is affecting this, but it's just the normal flow of execution in wp-login.php (line 572). Confirmed on trunk.

[boonebgorges]

The problem appears to be in bp_core_boot_spammer(), and in particular in how it bails when there is no current login attempt. About to commit a fix.

[boonebgorges]

(In [4371]) Return the correct value when no login is in process in bp_core_boot_spammer, so as to avoid errors on wp-login.php. Fixes #3212