Group activity permalinks are broken for private / hidden groups

[r-a-y]

Group activity permalinks for private / hidden groups redirect to $bp->root_domain whether you're a member of the group or not.

The changes made to BP_Activity_Activity::get() to merge ::get_specific() from BP 1.2 breaks this.

A potential fix requires changing $show_hidden to true on the activity router, single activity permalink screen action and activity permalink template.

FYI, the single activity permalink screen action handles access control, so we don't have to worry about the usage of "show_hidden" on the permalink template.

[r-a-y]

If the patch in #2579 is accepted, this ticket can be closed.

[DJPaul]

I like the approach of treating group permalink re-routed URLs the same as for the members component, so closing this in favour of #2579

[djpaul]

(In [4519]) Fix Group activity permalinks for private / hidden groups. Fixes #3210, props r-a-y

[r-a-y]

We should note this on the BPDevel blog and/or in the bp-default Theme Changelog on the BP codex.

This will be important as BP 1.3 will break group activity permalinks for those that have copied /bp-default/members/single/activity/permalink.php to their child theme.

[sbrajesh]

Just to notice, the problem exists with BuddyPress 1.2 branch and It is causing problem in BuddyPress 1.2.9.
For private group activities, you can not see the single activity page. It always redirects to home page. Any chances of getting it in 1.2 branch ?

[r-a-y]

You're right, Brajesh. r4111 (which made its way into BP 1.2.9) added some functionality from BP 1.3-trunk.

Patch needs to be backported to 1.2-branch.

[boonebgorges]

(In [4626]) Backports r4519 to the 1.2 branch so that private/hidden group activity permalinks display their content correctly. Fixes #3210. Props r-a-y

[boonebgorges]

It's unlikely that there will be another 1.2.x release, but I've backported it anyway.

[sbrajesh]

Thank you Ray for confirming.

and Thanks a ton Boone for porting the patch. Highly appreciate it.